ngAnimate ngClass digest fixes #3717
Conversation
|
|
||
| while(postDiquestQueue.length) { | ||
| try { | ||
| target.$eval(postDiquestQueue.shift()); |
There was a problem hiding this comment.
this should not be $eval, we should just call the fn in the queue without $eval or binding it to any context
There was a problem hiding this comment.
OK Done. Should I still keep a try {} / catch {} around it?
|
lgtm otherwise |
|
@IgorMinar there seems to be still something broken with ngClass and $$postDigest... Don't merge yet... |
ghost
assigned 
…gest cycle is complete
…leave and move animations
|
Closing this so it doesn't accidentally get merged. |
|
|
|
@mernen I agree, but if it has a double dollar then it's hidden for the time being. What do you think @IgorMinar about making it public down the road? |
|
Maybe. We need to learn how well it works before we commit to maintaining it as a public api. |
No description provided.